PHPLIB-1528 Add traits to implement Command and SDAM subscriber methods #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
PHPLIB-1528
branch
from
e432821 to
c0ebea6
Compare
GromNaN
force-pushed
the
PHPLIB-1528
branch
from
c0ebea6 to
46d63f7
Compare
|
Waiting investigation if we implement this in C in the mongodb extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1528
Make it easier to write partial implementations of interfaces
CommandSubscriberandSDAMSubscriber.Not adding a trait for
LogSubscriber, as this interface contains only 1 method.