Skip to content

Assert that the modifiers option is indeed deprecated #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Assert that the modifiers option is indeed deprecated #1451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/Operation/FindFunctionalTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ function () use ($modifiers): void {
['modifiers' => $modifiers],
);

$operation->execute($this->getPrimaryServer());
$this->assertDeprecated(
fn () => $operation->execute($this->getPrimaryServer()),
);
},
function (array $event) use ($expectedSort): void {
$this->assertEquals($expectedSort, $event['started']->getCommand()->sort ?? null);
Expand Down
3 changes: 2 additions & 1 deletion tests/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
use function sprintf;
use function strtr;

use const E_DEPRECATED;
use const E_USER_DEPRECATED;

abstract class TestCase extends BaseTestCase
Expand Down Expand Up @@ -171,7 +172,7 @@ protected function assertDeprecated(callable $execution): void

set_error_handler(function ($errno, $errstr) use (&$errors): void {
$errors[] = $errstr;
}, E_USER_DEPRECATED);
}, E_USER_DEPRECATED | E_DEPRECATED);

try {
call_user_func($execution);
Expand Down