Skip to content

Fix PHPUnit deprecation notices #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix PHPUnit deprecation notices #1526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/Operation/WatchFunctionalTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ public function testRewindMultipleTimesWithNoResults(): void
}

#[DataProvider('provideCodecOptions')]
public function testNoChangeAfterResumeBeforeInsert(array $options): void
public function testNoChangeAfterResumeBeforeInsert(array $options, Closure $getIdentifier): void
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if there's some annotation or other comment you'd like to see used to denote that this parameter is unused.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could be @phpstan-ignore constructor.unusedParameter, but if PHPStan doesn't complain, that's fine not having it.

{
$operation = new Watch(
$this->manager,
Expand Down Expand Up @@ -1427,7 +1427,7 @@ public function testGetResumeTokenReturnsOriginalResumeTokenOnEmptyBatch(): void
* - If neither the startAfter nor resumeAfter options were specified, the getResumeToken result must be empty.
*/
#[DataProvider('provideCodecOptions')]
public function testResumeTokenBehaviour(array $options): void
public function testResumeTokenBehaviour(array $options, Closure $getIdentifier): void
{
$this->skipIfServerVersion('<', '4.1.1', 'Testing resumeAfter and startAfter can only be tested on servers >= 4.1.1');
$this->skipIfIsShardedCluster('Resume token behaviour can\'t be reliably tested on sharded clusters.');
Expand Down