PHPLIB-1600 Accept stdClass objects in BSONDocument constructor
#1551
Conversation
tests/Model/BSONDocumentTest.php
Outdated
| protected string $baz = 'qux'; | ||
| }); | ||
| $this->assertSame('bar', $document->foo); | ||
| $this->assertObjectNotHasProperty('baz', $document); |
There was a problem hiding this comment.
This is essentially a test of ArrayObject itself. I think it'd be preferable to test bsonSerialize() (note: jsonSerialize() has the same implementation), so we can see what would actually get serialized to BSON.
My concern is that we should preserve the same encoding behavior as the extension, which will only encodes public properties.
See: https://3v4l.org/47VCv#v8.4.1
I think it's bit strange that the encoded names for protected and private properties still end up in output from ArrayObject::getArrayCopy(), and are preserved when casting back to an object. It's certainly odd that the stdClass instance resulting from that cast ends up with non-public properties, but that's likely an oddity of PHP itself.
If we can get away with only accepting stdClass|array, that might circumvent this issue.
There was a problem hiding this comment.
Thanks, I followed your suggestion on allowing only array|stdClass. That covers the request.
GromNaN
changed the title
object in BSONDocument constructorstdClass onjects in BSONDocument constructor
jmikola
left a comment
jmikola
left a comment
There was a problem hiding this comment.
LGTM although I think you can remove two lines from the test case.
GromNaN
changed the title
stdClass onjects in BSONDocument constructorstdClass objects in BSONDocument constructor
2 participants
Fixes PHPLIB-1600
Fixes #1549
Only
stdClassobjects are allowed, because other types of objects can have private/protected properties and we don't what to define the rule for this properties (keep or skip).