-
Notifications
You must be signed in to change notification settings - Fork 266
draft: augment yaml definitions with test schema #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.x
Are you sure you want to change the base?
Changes from 1 commit
39224b6
56a801b
7e64509
07cd9fc
7cb2274
cb2571c
e28803d
fd06dd6
64a44ad
6a34eda
cc2c832
c027132
3602303
7978e4f
b9b1d19
c2b1ee5
14623eb
943deb1
37a957c
34b9a20
4a2867b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ arguments: | |
name: specification | ||
type: | ||
- expression | ||
variadic: object | ||
variadic: object # XXX: This should somehow allow explicit typings for { fieldName: 1|0 } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The type is "expression", because any expression is accepted to compute a value. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. True. For IDE integrations/user support it's still valuable to be able to say "while this can be an arbitrary document, frequently it will have keys that match document keys and values which are either 0 or 1" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So we need an additional type for the projection. Maybe an enum:
And this parameter accepts an union of |
||
tests: | ||
- | ||
name: 'Include Specific Fields in Output Documents' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this value is not used.