-
Notifications
You must be signed in to change notification settings - Fork 268
[PHPLIB-1608] Implement prose tests for $lookup
support
#1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHPLIB-1608] Implement prose tests for $lookup
support
#1752
Conversation
2b3a5a9
to
ed00780
Compare
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
ed00780
to
270b4ad
Compare
This reverts commit e76d9f5.
270b4ad
to
955121d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests match the prose tests. Good work.
955121d
to
7f7c856
Compare
{ | ||
$this->skipIfServerVersion('<', '8.1.0', 'Lookup test case requires server version 8.1.0 or later'); | ||
$this->skipIfClientSideEncryptionIsNotSupported(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 CS fix and it's all good.
As laid out in the spec: mongodb/specifications@527e22d
7f7c856
to
d6e08a4
Compare
As laid out in the spec: mongodb/specifications@527e22d
Closes PHPLIB-1608