Skip to content

Conversation

paulinevos
Copy link
Contributor

As laid out in the spec: mongodb/specifications@527e22d

Closes PHPLIB-1608

@paulinevos paulinevos requested a review from a team as a code owner August 14, 2025 14:46
@paulinevos paulinevos requested a review from jmikola August 14, 2025 14:46
@paulinevos paulinevos force-pushed the feature/1608_lookup-csfe-qe branch from 2b3a5a9 to ed00780 Compare August 14, 2025 14:54
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
101595 1 101594 19105
View the full list of 1 ❄️ flaky tests
MongoDB.Tests.UnifiedSpecTests.UnifiedSpecTest::testSessions with data set "sessions/implicit sessions default causal consistency: afterClusterTime is not sent on retried read in implicit session when readConcern level is snapshot"

Flake rate in main: 10.53% (Passed 17 times, Failed 2 times)

Stack Traces | 0.741s run time
MongoDB\Tests\UnifiedSpecTests\UnifiedSpecTest::testSessions with data set "sessions/implicit sessions default causal consistency: afterClusterTime is not sent on retried read in implicit session when readConcern level is snapshot"
Failed asserting that expected value matches actual value.
$actual count is 0, expected 1
--- Expected
+++ Actual
@@ @@
-MongoDB\Model\BSONArray Object #118360 (
-    0 => MongoDB\Model\BSONDocument Object #118414 (
-        '_id' => 1,
-        'x' => 'snapshot',
-    ),
-)
+MongoDB\Model\BSONArray Object #118401 ()

.../UnifiedSpecTests/Constraint/Matches.php:112
.../tests/UnifiedSpecTests/ExpectedResult.php:48
.../tests/UnifiedSpecTests/Operation.php:164
.../tests/UnifiedSpecTests/UnifiedTestRunner.php:213
.../tests/UnifiedSpecTests/UnifiedTestRunner.php:105
.../tests/UnifiedSpecTests/UnifiedSpecTest.php:286

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@paulinevos paulinevos force-pushed the feature/1608_lookup-csfe-qe branch from ed00780 to 270b4ad Compare August 14, 2025 15:02
@paulinevos paulinevos force-pushed the feature/1608_lookup-csfe-qe branch from 270b4ad to 955121d Compare August 14, 2025 15:12
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests match the prose tests. Good work.

@paulinevos paulinevos force-pushed the feature/1608_lookup-csfe-qe branch from 955121d to 7f7c856 Compare August 18, 2025 13:25
{
$this->skipIfServerVersion('<', '8.1.0', 'Lookup test case requires server version 8.1.0 or later');
$this->skipIfClientSideEncryptionIsNotSupported();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 CS fix and it's all good.

@paulinevos paulinevos force-pushed the feature/1608_lookup-csfe-qe branch from 7f7c856 to d6e08a4 Compare August 18, 2025 14:53
@paulinevos paulinevos enabled auto-merge August 18, 2025 15:09
@paulinevos paulinevos merged commit aaa2237 into mongodb:v2.x Aug 18, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants