PHPLIB-1726: Add copilot instructions for reviews #1782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Sep 26, 2025
| - Focus on code quality, potential issues, and improvements not mentioned in the PR | ||
|
|
||
| ### PHP Version and Type Requirements | ||
| - Code must support **PHP 8.1 and newer** |
There was a problem hiding this comment.
Can we ask it to check the PHP constraints in composer.json so that we don't have to maintain the version number here?
Suggested change
| - Code must support **PHP 8.1 and newer** | |
| - The minimum PHP version supported is in the `./composer.json`. Code must support **this version and newer** |
| - Private/protected methods should also be fully typed | ||
| - Use strict scalar type declarations (`declare(strict_types=1)`) | ||
| - Prefer constructor property promotion when applicable | ||
| - Use named arguments for better readability in complex method calls |
There was a problem hiding this comment.
Suggested change
| - Use named arguments for better readability in complex method calls | |
| - Use named arguments for better readability in complex method calls to functions inside this package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-1726
This is a first draft of instructions for Copilot, aiming to improve the quality of reviews. The file itself was generated by Copilot itself and reviewed for completeness.