Skip to content

Conversation

@jmikola
Copy link
Member

@jmikola jmikola commented Jan 6, 2026

Removes a TODO for PHPLIB-1145, which was resolved as "won't fix". If you haven't read the original PR in #1075 though, you should. Some of @GromNaN's first work! 👏

@jmikola jmikola requested a review from a team as a code owner January 6, 2026 19:17
@jmikola jmikola requested a review from alcaeus January 6, 2026 19:17
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.77%. Comparing base (6cf2021) to head (a93bce7).
⚠️ Report is 2 commits behind head on v2.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               v2.x    #1820      +/-   ##
============================================
- Coverage     87.88%   87.77%   -0.11%     
- Complexity     3194     3205      +11     
============================================
  Files           426      427       +1     
  Lines          6345     6388      +43     
============================================
+ Hits           5576     5607      +31     
- Misses          769      781      +12     
Flag Coverage Δ
6.0-replica_set 86.56% <ø> (+0.68%) ⬆️
6.0-server 82.62% <ø> (+0.71%) ⬆️
6.0-sharded_cluster 86.34% <ø> (+0.69%) ⬆️
8.0-replica_set 87.63% <ø> (-0.17%) ⬇️
8.0-server 83.39% <ø> (+0.64%) ⬆️
8.0-sharded_cluster 87.46% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should target 2.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants