Skip to content

Conversation

NoahStapp
Copy link
Contributor

No description provided.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoahStapp NoahStapp merged commit 6e9bf1e into mongodb:master Sep 5, 2024
28 of 31 checks passed
@NoahStapp NoahStapp deleted the PYTHON-4708 branch September 5, 2024 14:20
@ShaneHarvey
Copy link
Member

Did you see my question on the jira ticket:

IIRC test.qcheck is very slow. Do we need to migrate it to async?

I'm not sure we need this PR.

@NoahStapp
Copy link
Contributor Author

Did you see my question on the jira ticket:

IIRC test.qcheck is very slow. Do we need to migrate it to async?

I'm not sure we need this PR.

Sorry, missed your comment. If we don't care to have this one specific test, we can remove qcheck entirely from this test suite. The BSON tests are the only other place it's used.

@ShaneHarvey
Copy link
Member

Eh it's not as slow as I thought. This is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants