PYTHON-4756 Add changelog note about dropping srv extra #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Sep 17, 2024
| and require installation using ``pip``. Attempts to invoke the ``setup.py`` file will raise an exception. | ||
| Additionally, ``pip`` >= 21.3 is now required for editable installs. | ||
| - We no longer support the ``srv`` extra, since ``dnspython`` is included as a dependency in PyMongo 4.7+. | ||
| Instead of ``pip install pymongo[srv]``, use ``pip install pymongo``. |
There was a problem hiding this comment.
Can you add the same for the "tls" extra which we also removed in the same commit?
There was a problem hiding this comment.
The tls extra was only valid for Python 2 which we dropped in PYTHON-2133 pymongo 4.0.
ShaneHarvey
reviewed
Sep 17, 2024
doc/changelog.rst
Outdated
| - We no longer support the ``srv`` or ``tls`` extras, since ``dnspython`` is included as a dependency in PyMongo 4.7+. | ||
| Instead of ``pip install pymongo[srv]`` or ``pip install pymongo[tls]``, use ``pip install pymongo``. | ||
| - We no longer support the ``tls`` extra, which was only valid for Python 2. | ||
| Instead of ``pip install pymongo[tls]`` or ``pip install pymongo[tls]``, use ``pip install pymongo``. |
There was a problem hiding this comment.
There's some duplication. How about:
- We no longer support the ``srv`` extra, since ``dnspython`` is included as a dependency in PyMongo 4.7+.
Instead of ``pip install pymongo[srv]``, use ``pip install pymongo``.
- We no longer support the ``tls`` extra, which was only valid for Python 2.
Instead of ``pip install pymongo[tls]``, use ``pip install pymongo``.
ShaneHarvey
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.