Skip to content

PYTHON-4574 - FaaS detection logic mistakenly identifies EKS as AWS Lambda #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

PYTHON-4574 - FaaS detection logic mistakenly identifies EKS as AWS Lambda #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f561efe
PYTHON-4574 - FaaS detection logic mistakenly identifies EKS as AWS L…
NoahStapp Oct 9, 2024
857b7ea
Update to reflect expected behavior
NoahStapp Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions test/asynchronous/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2019,6 +2019,22 @@ async def test_handshake_08_invalid_aws_ec2(self):
None,
)

async def test_handshake_09_container_with_provider(self):
await self._test_handshake(
{
ENV_VAR_K8S: "1",
"AWS_LAMBDA_RUNTIME_API": "1",
"AWS_REGION": "us-east-1",
"AWS_LAMBDA_FUNCTION_MEMORY_SIZE": "256",
},
{
"container": {"orchestrator": "kubernetes"},
"name": "aws.lambda",
"region": "us-east-1",
"memory_mb": 256,
},
)

def test_dict_hints(self):
self.db.t.find(hint={"x": 1})

Expand Down
16 changes: 16 additions & 0 deletions test/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1977,6 +1977,22 @@ def test_handshake_08_invalid_aws_ec2(self):
None,
)

def test_handshake_09_container_with_provider(self):
self._test_handshake(
{
ENV_VAR_K8S: "1",
"AWS_LAMBDA_RUNTIME_API": "1",
"AWS_REGION": "us-east-1",
"AWS_LAMBDA_FUNCTION_MEMORY_SIZE": "256",
},
{
"container": {"orchestrator": "kubernetes"},
"name": "aws.lambda",
"region": "us-east-1",
"memory_mb": 256,
},
)

def test_dict_hints(self):
self.db.t.find(hint={"x": 1})

Expand Down
Loading