-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-4834 Add __repr__ to IndexModel, SearchIndexModel #1909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a0bb143
PYTHON-4834 repr for SearchIndexModel, IndexModel
aclark4life d83a100
PYTHON-4834 repr for SearchIndexModel, IndexModel
aclark4life 7671303
PYTHON-4834 repr for SearchIndexModel, IndexModel
aclark4life 9747bf5
PYTHON-4834 repr for SearchIndexModel, IndexModel
aclark4life File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
# Copyright 2024-present MongoDB, Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Test the operations module.""" | ||
from __future__ import annotations | ||
|
||
from test import UnitTest, unittest | ||
|
||
from pymongo import ASCENDING, DESCENDING | ||
from pymongo.collation import Collation | ||
from pymongo.errors import OperationFailure | ||
from pymongo.operations import IndexModel, SearchIndexModel | ||
|
||
|
||
class TestOperationsBase(UnitTest): | ||
"""Base class for testing operations module.""" | ||
|
||
def assertRepr(self, obj): | ||
new_obj = eval(repr(obj)) | ||
self.assertEqual(type(new_obj), type(obj)) | ||
self.assertEqual(repr(new_obj), repr(obj)) | ||
|
||
|
||
class TestIndexModel(TestOperationsBase): | ||
"""Test IndexModel features.""" | ||
|
||
def test_repr(self): | ||
# Based on examples in test_collection.py | ||
self.assertRepr(IndexModel("hello")) | ||
self.assertRepr(IndexModel([("hello", DESCENDING), ("world", ASCENDING)])) | ||
self.assertRepr( | ||
IndexModel([("hello", DESCENDING), ("world", ASCENDING)], name="hello_world") | ||
) | ||
# Test all the kwargs | ||
self.assertRepr(IndexModel("name", name="name")) | ||
self.assertRepr(IndexModel("unique", unique=False)) | ||
self.assertRepr(IndexModel("background", background=True)) | ||
self.assertRepr(IndexModel("sparse", sparse=True)) | ||
self.assertRepr(IndexModel("bucketSize", bucketSize=1)) | ||
self.assertRepr(IndexModel("min", min=1)) | ||
self.assertRepr(IndexModel("max", max=1)) | ||
self.assertRepr(IndexModel("expireAfterSeconds", expireAfterSeconds=1)) | ||
self.assertRepr( | ||
IndexModel("partialFilterExpression", partialFilterExpression={"hello": "world"}) | ||
) | ||
self.assertRepr(IndexModel("collation", collation=Collation(locale="en_US"))) | ||
self.assertRepr(IndexModel("wildcardProjection", wildcardProjection={"$**": 1})) | ||
self.assertRepr(IndexModel("hidden", hidden=False)) | ||
# Test string literal | ||
self.assertEqual(repr(IndexModel("hello")), "IndexModel({'hello': 1}, name='hello_1')") | ||
self.assertEqual( | ||
repr(IndexModel({"hello": 1, "world": -1})), | ||
"IndexModel({'hello': 1, 'world': -1}, name='hello_1_world_-1')", | ||
) | ||
|
||
|
||
class TestSearchIndexModel(TestOperationsBase): | ||
"""Test SearchIndexModel features.""" | ||
|
||
def test_repr(self): | ||
self.assertRepr(SearchIndexModel({"hello": "hello"}, key=1)) | ||
aclark4life marked this conversation as resolved.
Show resolved
Hide resolved
|
||
self.assertEqual( | ||
repr(SearchIndexModel({"hello": "hello"}, key=1)), | ||
"SearchIndexModel(definition={'hello': 'hello'}, key=1)", | ||
) | ||
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ruff is still failing because it wants you to use f-strings. Do you have pre-commit set up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, forgot my
pre-commit install
! I think I just need to add a more meaningful test to theSearchIndexModel
test class to finish this.