PYTHON-4579 Stop gossiping $clusterTime on SDAM connections #1925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
force-pushed
the
PYTHON-4579
branch
from
22ae993 to
0e10dba
Compare
ShaneHarvey
force-pushed
the
PYTHON-4579
branch
from
0e10dba to
d38d930
Compare
3 tasks
NoahStapp
requested changes
Feb 25, 2025
pymongo/asynchronous/monitor.py
Outdated
| await self._topology.receive_cluster_time(details.get("$clusterTime")) | ||
| raise | ||
| return await self._check_once() | ||
| except asyncio.CancelledError: |
There was a problem hiding this comment.
Do we need this extra except? We only catch Exception instead of BaseException below, so CancelledError should be thrown uncaught.
There was a problem hiding this comment.
Ah this was a merge conflict artifact. I'll remove.
pymongo/asynchronous/topology.py
Outdated
| self._description = new_td | ||
| await self._update_servers() | ||
| self._receive_cluster_time_no_lock(server_description.cluster_time) | ||
| # TODO: Verify that app errors update the $clusterTime. |
There was a problem hiding this comment.
Tracked in https://jira.mongodb.org/browse/DRIVERS-3118. I'll remove this TODO.
|
Ready for another look. |
NoahStapp
requested changes
Feb 26, 2025
pymongo/asynchronous/monitor.py
Outdated
| # Initiate streaming hello (MongoDB 4.4+). | ||
| response = await conn._hello( | ||
| cluster_time, | ||
| None, |
There was a problem hiding this comment.
Can we remove cluster_time as a parameter to _hello entirely now?
sleepyStick
added a commit
to sleepyStick/mongo-python-driver
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON-4579 Stop gossiping $clusterTime on SDAM connections