PYTHON-4870 - MongoClient.address should block until a connection suc… #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Oct 15, 2024
| TOPOLOGY_TYPE.LoadBalanced, | ||
| TOPOLOGY_TYPE.Sharded, | ||
| ): | ||
| return None |
There was a problem hiding this comment.
I believe returning None when the TOPOLOGY_TYPE is ReplicaSetNoPrimary was intentional and should be reinstated. This also warrants a note in the changelog and a .. versionchanged::...
ShaneHarvey
reviewed
Oct 15, 2024
| @@ -59,7 +59,8 @@ def test_client(self): | |||
|
|
|||
| with self.assertRaises(ServerSelectionTimeoutError): | |||
| c.db.command("ping") | |||
| self.assertEqual(c.address, None) | |||
| with self.assertRaises(ServerSelectionTimeoutError): | |||
| _ = c.address | |||
There was a problem hiding this comment.
Returning None here was intentional behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ceeds or fails