Skip to content

PYTHON-4765 Resync server-selection spec #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

PYTHON-4765 Resync server-selection spec #1935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/server_selection_logging/operation-id.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@
}
},
{
"level": "debug",
"level": "info",
Copy link
Member

@ShaneHarvey ShaneHarvey Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we passing this test? We actually (intentionally) log this at debug level. See PYTHON-4261.

Copy link
Member

@ShaneHarvey ShaneHarvey Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're logging that line at "debug" level while the spec test claims it should be at "info" level. I would expect the test to fail. This indicates theres a bug in the test runner that we need to fix.

We also need to revert those lines to debug.

"component": "serverSelection",
"data": {
"message": "Waiting for suitable server to become available",
Expand Down Expand Up @@ -383,7 +383,7 @@
}
},
{
"level": "debug",
"level": "info",
"component": "serverSelection",
"data": {
"message": "Waiting for suitable server to become available",
Expand Down
2 changes: 1 addition & 1 deletion test/server_selection_logging/replica-set.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@
}
},
{
"level": "debug",
"level": "info",
"component": "serverSelection",
"data": {
"message": "Waiting for suitable server to become available",
Expand Down
2 changes: 1 addition & 1 deletion test/server_selection_logging/sharded.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@
}
},
{
"level": "debug",
"level": "info",
"component": "serverSelection",
"data": {
"message": "Waiting for suitable server to become available",
Expand Down
Loading
Loading