Skip to content

PYTHON-4865 Skip test_write_concern_failure tests temporarily #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2024
Merged

PYTHON-4865 Skip test_write_concern_failure tests temporarily #1936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5034b34
PYTHON-4865 Skip test_write_concern_failure tests temporarily
blink1073 Oct 16, 2024
b27040e
lint
blink1073 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/asynchronous/test_bulk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,6 +971,9 @@ async def cause_wtimeout(self, requests, ordered):
@async_client_context.require_replica_set
@async_client_context.require_secondaries_count(1)
async def test_write_concern_failure_ordered(self):
self.skipTest("Skipping until PYTHON-4865 is resolved.")
details = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is details=None?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To satisfy the type checker, since it is only defined in an exception block otherwise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack.


# Ensure we don't raise on wnote.
coll_ww = self.coll.with_options(write_concern=WriteConcern(w=self.w))
result = await coll_ww.bulk_write([DeleteOne({"something": "that does no exist"})])
Expand Down Expand Up @@ -1051,6 +1054,9 @@ async def test_write_concern_failure_ordered(self):
@async_client_context.require_replica_set
@async_client_context.require_secondaries_count(1)
async def test_write_concern_failure_unordered(self):
self.skipTest("Skipping until PYTHON-4865 is resolved.")
details = None

# Ensure we don't raise on wnote.
coll_ww = self.coll.with_options(write_concern=WriteConcern(w=self.w))
result = await coll_ww.bulk_write(
Expand Down
6 changes: 6 additions & 0 deletions test/test_bulk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,6 +969,9 @@ def cause_wtimeout(self, requests, ordered):
@client_context.require_replica_set
@client_context.require_secondaries_count(1)
def test_write_concern_failure_ordered(self):
self.skipTest("Skipping until PYTHON-4865 is resolved.")
details = None

# Ensure we don't raise on wnote.
coll_ww = self.coll.with_options(write_concern=WriteConcern(w=self.w))
result = coll_ww.bulk_write([DeleteOne({"something": "that does no exist"})])
Expand Down Expand Up @@ -1049,6 +1052,9 @@ def test_write_concern_failure_ordered(self):
@client_context.require_replica_set
@client_context.require_secondaries_count(1)
def test_write_concern_failure_unordered(self):
self.skipTest("Skipping until PYTHON-4865 is resolved.")
details = None

# Ensure we don't raise on wnote.
coll_ww = self.coll.with_options(write_concern=WriteConcern(w=self.w))
result = coll_ww.bulk_write([DeleteOne({"something": "that does no exist"})], ordered=False)
Expand Down
Loading