PYTHON-4903 Updated signature of Binary.from_vector to take a BinaryVector #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Oct 23, 2024
| padding: int = 0, | ||
| vector: Union[BinaryVector, list[int, float]], | ||
| dtype: Optional[BinaryVectorDtype] = None, | ||
| padding: Optional[int] = None, |
There was a problem hiding this comment.
Using a typing overload could be a cleaner solution here. Then you could properly convey to the type checker that dtype is required when vector is a list.
caseyclements
changed the title
caseyclements
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backward-compatible change of
Binary.from_vectorto take the BinaryVector dataclass as an alternative to separate list, dtype, and padding.