Skip to content

PYTHON-4903 Adds typing overloading to bson.binary.Binary.from_vector #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2024
Merged

PYTHON-4903 Adds typing overloading to bson.binary.Binary.from_vector #1967

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67c7ad2
Fixed typing.overload
caseyclements Oct 24, 2024
ec6fed4
test that from_vector(BinaryVector(), dtype=...) raises an error
caseyclements Nov 4, 2024
c971d84
Removed BETA advertisements on vector apis in binary.py
caseyclements Nov 4, 2024
ab265ae
Put test in a with clause to draw attention that mypy would catch the…
caseyclements Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion bson/binary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import struct
from dataclasses import dataclass
from enum import Enum
from typing import TYPE_CHECKING, Any, Optional, Sequence, Tuple, Type, Union
from typing import TYPE_CHECKING, Any, Optional, Sequence, Tuple, Type, Union, overload
from uuid import UUID

"""Tools for representing BSON binary data.
Expand Down Expand Up @@ -397,6 +397,18 @@ def as_uuid(self, uuid_representation: int = UuidRepresentation.STANDARD) -> UUI
f"cannot decode subtype {self.subtype} to {UUID_REPRESENTATION_NAMES[uuid_representation]}"
)

@classmethod
@overload
def from_vector(cls: Type[Binary], vector: BinaryVector) -> Binary:
...

@classmethod
@overload
def from_vector(
cls: Type[Binary], vector: list[int, float], dtype: BinaryVectorDtype, padding: int = 0
) -> Binary:
...

@classmethod
def from_vector(
cls: Type[Binary],
Expand Down
Loading