Skip to content

PYTHON-4916 - URI options spec tests specify empty options when the i… #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

PYTHON-4916 - URI options spec tests specify empty options when the i… #1991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/uri_options/auth-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"tests": [
{
"description": "Valid auth options are parsed correctly (GSSAPI)",
"uri": "mongodb://foo:[email protected]/?authMechanism=GSSAPI&authMechanismProperties=SERVICE_NAME:other,CANONICALIZE_HOST_NAME:true&authSource=$external",
"uri": "mongodb://foo:[email protected]/?authMechanism=GSSAPI&authMechanismProperties=SERVICE_NAME:other,CANONICALIZE_HOST_NAME:forward,SERVICE_HOST:example.com&authSource=$external",
"valid": true,
"warning": false,
"hosts": null,
Expand All @@ -11,7 +11,8 @@
"authMechanism": "GSSAPI",
"authMechanismProperties": {
"SERVICE_NAME": "other",
"CANONICALIZE_HOST_NAME": true
"SERVICE_HOST": "example.com",
"CANONICALIZE_HOST_NAME": "forward"
},
"authSource": "$external"
}
Expand Down
6 changes: 3 additions & 3 deletions test/uri_options/compression-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Too low zlibCompressionLevel causes a warning",
Expand All @@ -44,7 +44,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Too high zlibCompressionLevel causes a warning",
Expand All @@ -53,7 +53,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
}
]
}
6 changes: 3 additions & 3 deletions test/uri_options/concern-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Too low wTimeoutMS causes a warning",
Expand All @@ -52,7 +52,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Invalid journal causes a warning",
Expand All @@ -61,7 +61,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
}
]
}
38 changes: 19 additions & 19 deletions test/uri_options/connection-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Too low connectTimeoutMS causes a warning",
Expand All @@ -36,7 +36,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Non-numeric heartbeatFrequencyMS causes a warning",
Expand All @@ -45,7 +45,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Too low heartbeatFrequencyMS causes a warning",
Expand All @@ -54,7 +54,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Non-numeric localThresholdMS causes a warning",
Expand All @@ -63,7 +63,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Too low localThresholdMS causes a warning",
Expand All @@ -72,7 +72,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Invalid retryWrites causes a warning",
Expand All @@ -81,7 +81,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Non-numeric serverSelectionTimeoutMS causes a warning",
Expand All @@ -90,7 +90,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Too low serverSelectionTimeoutMS causes a warning",
Expand All @@ -99,7 +99,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Non-numeric socketTimeoutMS causes a warning",
Expand All @@ -108,7 +108,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Too low socketTimeoutMS causes a warning",
Expand All @@ -117,7 +117,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "directConnection=true",
Expand All @@ -137,7 +137,7 @@
"warning": false,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "directConnection=false",
Expand Down Expand Up @@ -168,7 +168,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "loadBalanced=true",
Expand Down Expand Up @@ -211,7 +211,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "loadBalanced=true with multiple hosts causes an error",
Expand All @@ -220,7 +220,7 @@
"warning": false,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "loadBalanced=true with directConnection=true causes an error",
Expand All @@ -229,7 +229,7 @@
"warning": false,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "loadBalanced=true with replicaSet causes an error",
Expand All @@ -238,7 +238,7 @@
"warning": false,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "timeoutMS=0",
Expand All @@ -258,7 +258,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Too low timeoutMS causes a warning",
Expand All @@ -267,7 +267,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
}
]
}
8 changes: 4 additions & 4 deletions test/uri_options/connection-pool-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Too low maxIdleTimeMS causes a warning",
Expand All @@ -30,7 +30,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "maxPoolSize=0 does not error",
Expand Down Expand Up @@ -61,7 +61,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "maxConnecting<0 causes a warning",
Expand All @@ -70,7 +70,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
}
]
}
2 changes: 1 addition & 1 deletion test/uri_options/sdam-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
}
]
}
2 changes: 1 addition & 1 deletion test/uri_options/single-threaded-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
}
]
}
12 changes: 6 additions & 6 deletions test/uri_options/srv-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"warning": false,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "SRV URI with srvMaxHosts",
Expand All @@ -38,7 +38,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "SRV URI with invalid type for srvMaxHosts",
Expand All @@ -47,7 +47,7 @@
"warning": true,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "Non-SRV URI with srvMaxHosts",
Expand All @@ -56,7 +56,7 @@
"warning": false,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "SRV URI with positive srvMaxHosts and replicaSet",
Expand All @@ -65,7 +65,7 @@
"warning": false,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "SRV URI with positive srvMaxHosts and loadBalanced=true",
Expand All @@ -74,7 +74,7 @@
"warning": false,
"hosts": null,
"auth": null,
"options": {}
"options": null
},
{
"description": "SRV URI with positive srvMaxHosts and loadBalanced=false",
Expand Down
Loading
Loading