Skip to content

PYTHON-4982 Remove redundant configureFailPoint #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

PYTHON-4982 Remove redundant configureFailPoint #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions test/asynchronous/test_retryable_reads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,8 @@ async def test_retryable_reads_in_sharded_cluster_multiple_available(self):
retryReads=True,
)

async with self.fail_point(fail_command):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already set the failpoint on both mongoses above.

with self.assertRaises(AutoReconnect):
await client.t.t.find_one({})
with self.assertRaises(AutoReconnect):
await client.t.t.find_one({})

# Disable failpoints on each mongos
for client in mongos_clients:
Expand Down
5 changes: 2 additions & 3 deletions test/test_retryable_reads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,8 @@ def test_retryable_reads_in_sharded_cluster_multiple_available(self):
retryReads=True,
)

with self.fail_point(fail_command):
with self.assertRaises(AutoReconnect):
client.t.t.find_one({})
with self.assertRaises(AutoReconnect):
client.t.t.find_one({})

# Disable failpoints on each mongos
for client in mongos_clients:
Expand Down
Loading