Skip to content

PYTHON-4991 Fix perf client.bulkWrite perf regression #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

PYTHON-4991 Fix perf client.bulkWrite perf regression #2056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pymongo/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import datetime
import random
import struct
from collections import ChainMap
from io import BytesIO as _BytesIO
from typing import (
TYPE_CHECKING,
Expand Down Expand Up @@ -1117,14 +1116,14 @@ def _check_doc_size_limits(
op_doc[op_type] = ns_info[namespace] # type: ignore[index]

# Since the data document itself is nested within the insert document
# it won't be automatically re-ordered by the BSON conversion.
# We use ChainMap here to make the _id field the first field instead.
# it won't be automatically re-ordered by the BSON conversion, so we need
# to encode it directly as a top-level document first.
doc_to_encode = op_doc
if real_op_type == "insert":
doc = op_doc["document"]
if not isinstance(doc, RawBSONDocument):
doc_to_encode = op_doc.copy() # type: ignore[attr-defined] # Shallow copy
doc_to_encode["document"] = ChainMap(doc, {"_id": doc["_id"]}) # type: ignore[index]
doc_to_encode["document"] = RawBSONDocument(_dict_to_bson(doc, False, opts)) # type: ignore[index]

# Encode current operation doc and, if newly added, namespace doc.
op_doc_encoded = _dict_to_bson(doc_to_encode, False, opts)
Expand Down
Loading