Skip to content

PYTHON-5043: Fix list[int, float] typo in binary.py #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 21, 2025
Merged

PYTHON-5043: Fix list[int, float] typo in binary.py #2066

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ef1b27
fixed typing on binary.py
Jibola Jan 17, 2025
05cae25
ruff format
Jibola Jan 17, 2025
3d7ae53
use Union[list]
Jibola Jan 17, 2025
c3cdc27
added typing tests
Jibola Jan 17, 2025
b575225
only typecheck
Jibola Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions bson/binary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,14 +405,17 @@ def from_vector(cls: Type[Binary], vector: BinaryVector) -> Binary:
@classmethod
@overload
def from_vector(
cls: Type[Binary], vector: list[int, float], dtype: BinaryVectorDtype, padding: int = 0
cls: Type[Binary],
vector: Union[list[int], list[float]],
dtype: BinaryVectorDtype,
padding: int = 0,
) -> Binary:
...

@classmethod
def from_vector(
cls: Type[Binary],
vector: Union[BinaryVector, list[int, float]],
vector: Union[BinaryVector, list[int], list[float]],
dtype: Optional[BinaryVectorDtype] = None,
padding: Optional[int] = None,
) -> Binary:
Expand Down
Loading