Detailed error message for better debugging #2075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tejaschauhan36912
commented
Jan 23, 2025
tejaschauhan36912
commented
- Enhanced error message with more details for better debugging experience.
sleepyStick
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Hi! Thanks for doing this!
Just a couple quick fixes, but otherwise this is looking great!
Would you mind running pre-commit run --all-files so the synchronous files are generated properly? In general, we edit files in pymongo/asynchronous/* instead of pymongo/synchronous/*.
Thanks!
sleepyStick
requested changes
Jan 25, 2025
There was a problem hiding this comment.
The synchronous version of this file (and a few others) don't seem to have all the changes here. (It has some but not all.) Could you try re-running pre-commit (pre-commit run --all-files) and then committing again?
|
I will create this same PR again. |
|
@sleepyStick, I have added a new PR, please review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.