Skip to content

PYTHON-5080 - Convert test.test_examples to async #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 5, 2025
Merged

PYTHON-5080 - Convert test.test_examples to async #2097

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a277e72
PYTHON-5080 - Convert test.test_examples to async
NoahStapp Jan 29, 2025
9706379
Fix typing
NoahStapp Jan 29, 2025
42bf75c
Fix predicates
NoahStapp Jan 30, 2025
a131f48
Fix whitespace
NoahStapp Jan 30, 2025
19ce266
Merge branch 'master' into PYTHON-5080
NoahStapp Jan 31, 2025
5a1f434
Merge branch 'master' into PYTHON-5080
NoahStapp Feb 4, 2025
b293c94
Refactor
NoahStapp Feb 4, 2025
524de44
Simplify code
NoahStapp Feb 4, 2025
9c26277
Avoid tight loop
NoahStapp Feb 4, 2025
145e787
Use try/finally to set stopped
NoahStapp Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions test/asynchronous/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,14 +381,14 @@ def disable(self):


class ConcurrentRunner(PARENT):
def __init__(self, name, *args, **kwargs):
def __init__(self, **kwargs):
if _IS_SYNC:
super().__init__(*args, **kwargs)
self.name = name
super().__init__(**kwargs)
self.name = kwargs.get("name", "ConcurrentRunner")
self.stopped = False
self.task = None
if "target" in kwargs:
self.target = kwargs["target"]
self.target = kwargs.get("target", None)
self.args = kwargs.get("args", [])

if not _IS_SYNC:

Expand All @@ -404,5 +404,8 @@ def is_alive(self):

async def run(self):
if self.target:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would "target" ever be None?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, we'd want it to throw an error here instead of being a silent no-op.

await self.target()
if self.args:
await self.target(*self.args)
else:
await self.target()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await self.target(*self.args) will work even if self.args is an empty list so this code can be simplified.

self.stopped = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to set stopped to try even when target raises? If so I suggest using try/finally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'd say so.

Loading
Loading