PYTHON-4993 - Reevaluate handling of asyncio.CancelledError #2132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of these could be added back in with https://jira.mongodb.org/browse/PYTHON-4745 depending on what we decide on. |
ShaneHarvey
reviewed
Feb 7, 2025
pymongo/_client_bulk_shared.py
Outdated
| ) | ||
| raise OperationFailure(errmsg, code, full_result) | ||
| if isinstance(full_result["error"], BaseException): | ||
| if isinstance(full_result["error"], asyncio.CancelledError): |
There was a problem hiding this comment.
Is this actually needed? Like do we catch BaseException where _throw_client_bulk_write_exception is called? Or is this added just to be safe?
There was a problem hiding this comment.
Good catch. We don't catch BaseException when _throw_client_bulk_write_exception is called, so this can be removed.
ShaneHarvey
previously approved these changes
Feb 10, 2025
ShaneHarvey
reviewed
Feb 10, 2025
No, looking into now. |
ShaneHarvey
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.