PYTHON-4540 Convert libmongocrypt download to python #2148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
requested changes
Feb 18, 2025
.evergreen/scripts/setup_tests.py
Outdated
|
|
||
| def setup_libmongocrypt(): | ||
| target = "" | ||
| if os.name == "nt": |
There was a problem hiding this comment.
Could we encapsulate this platform detection logic into a helper method? I assume we'll need to do this a lot as we migrate from bash to Python.
NoahStapp
previously approved these changes
Feb 18, 2025
|
LGTM pending tests passing. |
|
Needs another review because I had to fix the use of |
NoahStapp
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing build: https://spruce.mongodb.com/version/67af719537cb1f00076ddea6/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC