Skip to content

Conversation

NoahStapp
Copy link
Contributor

There's a lot of churn here due to the file renaming and shuffling. Reviewers should focus on the new test/asynchronous/utils.py and its synchronous companion, which reduce code duplication. I've also removed server_started_with_option, server_started_with_auth, get_command_line, which were unused helpers.

@sleepyStick
Copy link
Contributor

@NoahStapp
Copy link
Contributor Author

sleepyStick
sleepyStick previously approved these changes Feb 24, 2025
Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!

@NoahStapp
Copy link
Contributor Author

NoahStapp commented Mar 11, 2025

The test failure is also present in master, tracked in https://jira.mongodb.org/browse/PYTHON-5198.

@NoahStapp NoahStapp requested a review from sleepyStick March 11, 2025 19:06
@NoahStapp NoahStapp merged commit 34ca759 into mongodb:master Mar 12, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants