Skip to content

PYTHON-5167 Async Condition.wait has to reacquire the lock even after a timeout #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

PYTHON-5167 Async Condition.wait has to reacquire the lock even after a timeout #2165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67759cd
PYTHON-5167 Async Condition.wait has to reacquire the lock even after…
ShaneHarvey Feb 28, 2025
ce4eeb2
PYTHON-5167 Shield wait() from wait_for cancel
ShaneHarvey Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pymongo/lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,11 @@ def _release_locks() -> None:


async def _async_cond_wait(condition: Condition, timeout: Optional[float]) -> bool:
fut = asyncio.ensure_future(condition.wait())
try:
return await wait_for(condition.wait(), timeout)
return await wait_for(asyncio.shield(fut), timeout)
except asyncio.TimeoutError:
await fut
return False


Expand Down
Loading