-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-4946 - Add GridFSBucket.rename_by_name #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
cd4b1db
2103d67
f7da415
91dbda3
1218176
9c0bc9f
c57e6c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1021,6 +1021,35 @@ async def rename( | |
"matched file_id %i" % (new_filename, file_id) | ||
) | ||
|
||
async def rename_by_name( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of adding a new method for this, should we consider overloading the existing rename method? For example: >>> fs.rename(file_id, "new") # rename by id
>>> fs.rename(filename="old", new_filename="new") # rename by name The pro is we have less apis to maintain. I guess a con is that the user could accidentally mix up the file_id and filename params. Note I'm not advocating for either, I just think we should consider it and maybe ask the spec author about it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like this suggestion--both methods have nearly identical bodies, so combining them makes sense. For #2218, the two methods have slightly different bodies, but still similar enough that we could do the same thing there. Thoughts? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What would the method signatures looks like (including type hints)? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After trying this out a bit, I think it's a little too confusing/unclear to combine them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you share the signatures for posterity? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
self, filename: str, new_filename: str, session: Optional[AsyncClientSession] = None | ||
) -> None: | ||
"""Renames the stored file with the specified filename. | ||
|
||
For example:: | ||
|
||
my_db = AsyncMongoClient().test | ||
fs = AsyncGridFSBucket(my_db) | ||
await fs.upload_from_stream("test_file", "data I want to store!") | ||
await fs.rename_by_name("test_file", "new_test_name") | ||
|
||
Raises :exc:`~gridfs.errors.NoFile` if no file with the given filename exists. | ||
|
||
:param filename: The filename of the file to be renamed. | ||
:param new_filename: The new name of the file. | ||
:param session: a :class:`~pymongo.client_session.AsyncClientSession` | ||
|
||
.. versionadded:: 4.12 | ||
""" | ||
_disallow_transactions(session) | ||
result = await self._files.update_many( | ||
{"filename": filename}, {"$set": {"filename": new_filename}}, session=session | ||
) | ||
if not result.matched_count: | ||
raise NoFile( | ||
f"no files could be renamed {new_filename!r} because none matched filename {filename!r}" | ||
) | ||
|
||
|
||
class AsyncGridIn: | ||
"""Class to write data to GridFS.""" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1015,6 +1015,35 @@ def rename( | |
"matched file_id %i" % (new_filename, file_id) | ||
) | ||
|
||
def rename_by_name( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add some hand written tests for this too like test_rename in test_gridfs_bucket. That way we get some signal on typing and the UX. |
||
self, filename: str, new_filename: str, session: Optional[ClientSession] = None | ||
) -> None: | ||
"""Renames the stored file with the specified filename. | ||
|
||
For example:: | ||
|
||
my_db = MongoClient().test | ||
fs = GridFSBucket(my_db) | ||
fs.upload_from_stream("test_file", "data I want to store!") | ||
fs.rename_by_name("test_file", "new_test_name") | ||
|
||
Raises :exc:`~gridfs.errors.NoFile` if no file with the given filename exists. | ||
|
||
:param filename: The filename of the file to be renamed. | ||
:param new_filename: The new name of the file. | ||
:param session: a :class:`~pymongo.client_session.ClientSession` | ||
|
||
.. versionadded:: 4.12 | ||
""" | ||
_disallow_transactions(session) | ||
result = self._files.update_many( | ||
{"filename": filename}, {"$set": {"filename": new_filename}}, session=session | ||
) | ||
if not result.matched_count: | ||
raise NoFile( | ||
f"no files could be renamed {new_filename!r} because none matched filename {filename!r}" | ||
) | ||
|
||
|
||
class GridIn: | ||
"""Class to write data to GridFS.""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of file revisions.
->of a file with multiple revisions.