PYTHON-4557 - Add log message for retried commands #2248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Mar 31, 2025
| if self._retrying: | ||
| _debug_log( | ||
| _COMMAND_LOGGER, | ||
| message=f"Retrying write attempt number {self._attempt_number}", |
There was a problem hiding this comment.
Is there any fields we should add here that can be used to correlate the two retry attempts? Maybe _operation and/or _operation_id?
There was a problem hiding this comment.
With those fields added, this is what the message looks like:
{"message": "Retrying read attempt number <x> for operation 'op_name' with id <id>}"}
ShaneHarvey
requested changes
Apr 1, 2025
pymongo/asynchronous/mongo_client.py
Outdated
| _debug_log( | ||
| _COMMAND_LOGGER, | ||
| message=f"Retrying write attempt number {self._attempt_number}", | ||
| message=f"Retrying write attempt number {self._attempt_number} for operation `{self._operation}` with id {self._operation_id}", |
There was a problem hiding this comment.
Let's use the logging format:
_debug_log(
_COMMAND_LOGGER,
message=f"Retrying write attempt number {self._attempt_number}",
clientId=...,
commandName=self._operation,
operationId=self._operation_id
ShaneHarvey
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.