Skip to content

PYTHON-5288: SRV hostname validation fails when resolver and resolved hostnames are identical with three domain levels #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2025
Merged

PYTHON-5288: SRV hostname validation fails when resolver and resolved hostnames are identical with three domain levels #2272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c767cd4
Fix SRV hostname validation fails
aclark4life Apr 9, 2025
c2bc931
Review fixes
aclark4life Apr 9, 2025
66d045e
Check length of fqdn not srv host
aclark4life Apr 9, 2025
0f1f8a7
Move test case to separate test
aclark4life Apr 9, 2025
03ccebe
Use newly defined srv_host
aclark4life Apr 9, 2025
0dc962b
Use split_fqdn
aclark4life Apr 9, 2025
e474e22
Add changelog entry
aclark4life Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymongo/asynchronous/srv_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ async def _get_srv_response_and_hosts(

# Validate hosts
for node in nodes:
if self.__fqdn == node[0].lower():
if self.__fqdn == node[0].lower() and len(node[0].split(".")) < 3:
raise ConfigurationError(
"Invalid SRV host: return address is identical to SRV hostname"
)
Expand Down
2 changes: 1 addition & 1 deletion pymongo/synchronous/srv_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def _get_srv_response_and_hosts(

# Validate hosts
for node in nodes:
if self.__fqdn == node[0].lower():
if self.__fqdn == node[0].lower() and len(node[0].split(".")) < 3:
raise ConfigurationError(
"Invalid SRV host: return address is identical to SRV hostname"
)
Expand Down
Loading