Skip to content

PYTHON-5371 - Pass repr(ServerDescription) to logging #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025
Merged

PYTHON-5371 - Pass repr(ServerDescription) to logging #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e475143
PYTHON-5371 - Skip test_continuous_network_errors when debug logs are…
NoahStapp May 2, 2025
bd002b9
Pass ServerDescription.__repr__ to SDAM logging
NoahStapp May 2, 2025
221d9e5
Use repr()
NoahStapp May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pymongo/asynchronous/topology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ def __init__(self, topology_settings: TopologySettings):
_SDAM_LOGGER,
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
topologyId=self._topology_id,
previousDescription=initial_td,
newDescription=self._description,
previousDescription=repr(initial_td),
newDescription=repr(self._description),
)

for seed in topology_settings.seeds:
Expand Down Expand Up @@ -514,8 +514,8 @@ async def _process_change(
_SDAM_LOGGER,
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
topologyId=self._topology_id,
previousDescription=td_old,
newDescription=self._description,
previousDescription=repr(td_old),
newDescription=repr(self._description),
)

# Shutdown SRV polling for unsupported cluster types.
Expand Down Expand Up @@ -581,8 +581,8 @@ async def _process_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
_SDAM_LOGGER,
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
topologyId=self._topology_id,
previousDescription=td_old,
newDescription=self._description,
previousDescription=repr(td_old),
newDescription=repr(self._description),
)

async def on_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
Expand Down Expand Up @@ -747,8 +747,8 @@ async def close(self) -> None:
_SDAM_LOGGER,
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
topologyId=self._topology_id,
previousDescription=old_td,
newDescription=self._description,
previousDescription=repr(old_td),
newDescription=repr(self._description),
)
_debug_log(
_SDAM_LOGGER, message=_SDAMStatusMessage.STOP_TOPOLOGY, topologyId=self._topology_id
Expand Down
16 changes: 8 additions & 8 deletions pymongo/synchronous/topology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ def __init__(self, topology_settings: TopologySettings):
_SDAM_LOGGER,
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
topologyId=self._topology_id,
previousDescription=initial_td,
newDescription=self._description,
previousDescription=repr(initial_td),
newDescription=repr(self._description),
)

for seed in topology_settings.seeds:
Expand Down Expand Up @@ -514,8 +514,8 @@ def _process_change(
_SDAM_LOGGER,
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
topologyId=self._topology_id,
previousDescription=td_old,
newDescription=self._description,
previousDescription=repr(td_old),
newDescription=repr(self._description),
)

# Shutdown SRV polling for unsupported cluster types.
Expand Down Expand Up @@ -581,8 +581,8 @@ def _process_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
_SDAM_LOGGER,
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
topologyId=self._topology_id,
previousDescription=td_old,
newDescription=self._description,
previousDescription=repr(td_old),
newDescription=repr(self._description),
)

def on_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
Expand Down Expand Up @@ -745,8 +745,8 @@ def close(self) -> None:
_SDAM_LOGGER,
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
topologyId=self._topology_id,
previousDescription=old_td,
newDescription=self._description,
previousDescription=repr(old_td),
newDescription=repr(self._description),
)
_debug_log(
_SDAM_LOGGER, message=_SDAMStatusMessage.STOP_TOPOLOGY, topologyId=self._topology_id
Expand Down
Loading