Skip to content

PYTHON-5414 Add test for hostname verification error message regression #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

PYTHON-5414 Add test for hostname verification error message regression #2385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/asynchronous/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ async def test_cert_ssl_validation_hostname_matching(self):

response = await self.client.admin.command(HelloCompat.LEGACY_CMD)

with self.assertRaises(ConnectionFailure):
with self.assertRaises(ConnectionFailure) as cm:
await connected(
self.simple_client(
"server",
Expand All @@ -335,6 +335,8 @@ async def test_cert_ssl_validation_hostname_matching(self):
**self.credentials, # type: ignore[arg-type]
)
)
# PYTHON-5414 Check for "module service_identity has no attribute SICertificateError"
self.assertNotIn("has no attribute", str(cm.exception))

await connected(
self.simple_client(
Expand Down
4 changes: 3 additions & 1 deletion test/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ def test_cert_ssl_validation_hostname_matching(self):

response = self.client.admin.command(HelloCompat.LEGACY_CMD)

with self.assertRaises(ConnectionFailure):
with self.assertRaises(ConnectionFailure) as cm:
connected(
self.simple_client(
"server",
Expand All @@ -335,6 +335,8 @@ def test_cert_ssl_validation_hostname_matching(self):
**self.credentials, # type: ignore[arg-type]
)
)
# PYTHON-5414 Check for "module service_identity has no attribute SICertificateError"
self.assertNotIn("has no attribute", str(cm.exception))

connected(
self.simple_client(
Expand Down
Loading