Skip to content

PYTHON-5423 Always use subprocess.run instead of subprocess.check_call or subprocess.call #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

PYTHON-5423 Always use subprocess.run instead of subprocess.check_call or subprocess.call #2412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hatch_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def initialize(self, version, build_data):
here = Path(__file__).parent.resolve()
sys.path.insert(0, str(here))

subprocess.check_call([sys.executable, "_setup.py", "build_ext", "-i"])
subprocess.run([sys.executable, "_setup.py", "build_ext", "-i"], check=True)

# Ensure wheel is marked as binary and contains the binary files.
build_data["infer_tag"] = True
Expand Down
2 changes: 1 addition & 1 deletion test/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ def fips_enabled(self):
if self._fips_enabled is not None:
return self._fips_enabled
try:
subprocess.check_call(["fips-mode-setup", "--is-enabled"])
subprocess.run(["fips-mode-setup", "--is-enabled"], check=True)
self._fips_enabled = True
except (subprocess.SubprocessError, FileNotFoundError):
self._fips_enabled = False
Expand Down
2 changes: 1 addition & 1 deletion test/asynchronous/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ def fips_enabled(self):
if self._fips_enabled is not None:
return self._fips_enabled
try:
subprocess.check_call(["fips-mode-setup", "--is-enabled"])
subprocess.run(["fips-mode-setup", "--is-enabled"], check=True)
self._fips_enabled = True
except (subprocess.SubprocessError, FileNotFoundError):
self._fips_enabled = False
Expand Down
Loading