Skip to content

PYTHON-4779 Use slots for Selection and TopologyDescription #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

PYTHON-4779 Use slots for Selection and TopologyDescription #2414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fff8bf2
PYTHON-4779 Use slots for Selection and TopologyDescription
blink1073 Jul 1, 2025
b60bef1
add missing slot
blink1073 Jul 1, 2025
55bdc70
fix slot name
blink1073 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pymongo/server_selectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
class Selection:
"""Input or output of a server selector function."""

__slots__ = ("topology_description", "server_descriptions", "primary", "common_wire_version")

@classmethod
def from_topology_description(cls, topology_description: TopologyDescription) -> Selection:
known_servers = topology_description.known_servers
Expand Down
11 changes: 11 additions & 0 deletions pymongo/topology_description.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,17 @@ class _TopologyType(NamedTuple):


class TopologyDescription:
__slots__ = (
"_topology_type",
"_topology_settings",
"_replica_set_name",
"_server_descriptions",
"_max_set_version",
"_max_election_id",
"_incompatible_err",
"_ls_timeout_minutes",
)

def __init__(
self,
topology_type: int,
Expand Down
Loading