Skip to content

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from sleepyStick July 17, 2025 19:52
@blink1073 blink1073 requested a review from a team as a code owner July 17, 2025 19:52
Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait JK just saw the test failures HAHA

async def test_explain_csot(self):
# Create a MongoClient with command monitoring enabled (referred to as client).
listener = AllowListEventListener("explain")
client = await self.rs_or_single_client(event_listeners=[listener])
Copy link
Contributor

@sleepyStick sleepyStick Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be self.async_rs_or_single_client

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I accidentally created the sync version first, then hand-ported it.

@blink1073 blink1073 requested a review from sleepyStick July 18, 2025 00:49
Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit cf26301 into mongodb:master Jul 18, 2025
81 checks passed
@blink1073 blink1073 deleted the PYTHON-4677 branch July 18, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants