-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Spec Resync] 07-28-2025 #2447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Spec Resync] 07-28-2025 #2447
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
456d7cd
resyncing specs 07-28-2025
f2ded85
Fix failures
NoahStapp d54756e
Fix server selection logging
NoahStapp f505728
Fix PYTHON-4261.patch whitespace
NoahStapp 324bb15
Fix PYTHON-2673.patch
NoahStapp 7736b3c
Remove skipped modifyCollection tests
NoahStapp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| diff --git a/test/load_balancer/cursors.json b/test/load_balancer/cursors.json | ||
| index 43e4fbb4f..4e2a55fd4 100644 | ||
| --- a/test/load_balancer/cursors.json | ||
| +++ b/test/load_balancer/cursors.json | ||
| @@ -376,7 +376,7 @@ | ||
| ] | ||
| }, | ||
| { | ||
| + "description": "pinned connections are not returned after an network error during getMore", | ||
| - "description": "pinned connections are returned after an network error during getMore", | ||
| "operations": [ | ||
| { | ||
| "name": "failPoint", | ||
| @@ -440,7 +440,7 @@ | ||
| "object": "testRunner", | ||
| "arguments": { | ||
| "client": "client0", | ||
| + "connections": 1 | ||
| - "connections": 0 | ||
| } | ||
| }, | ||
| { | ||
| @@ -659,7 +659,7 @@ | ||
| ] | ||
| }, | ||
| { | ||
| + "description": "pinned connections are not returned to the pool after a non-network error on getMore", | ||
| - "description": "pinned connections are returned to the pool after a non-network error on getMore", | ||
| "operations": [ | ||
| { | ||
| "name": "failPoint", | ||
| @@ -715,7 +715,7 @@ | ||
| "object": "testRunner", | ||
| "arguments": { | ||
| "client": "client0", | ||
| + "connections": 1 | ||
| - "connections": 0 | ||
| } | ||
| }, | ||
| { | ||
| diff --git a/test/load_balancer/sdam-error-handling.json b/test/load_balancer/sdam-error-handling.json | ||
| index 63aabc04d..462fa0aac 100644 | ||
| --- a/test/load_balancer/sdam-error-handling.json | ||
| +++ b/test/load_balancer/sdam-error-handling.json | ||
| @@ -366,6 +366,9 @@ | ||
| { | ||
| "connectionCreatedEvent": {} | ||
| }, | ||
| + { | ||
| + "poolClearedEvent": {} | ||
| + }, | ||
| { | ||
| "connectionClosedEvent": { | ||
| "reason": "error" | ||
| @@ -378,9 +375,6 @@ | ||
| "connectionCheckOutFailedEvent": { | ||
| "reason": "connectionError" | ||
| } | ||
| - }, | ||
| - { | ||
| - "poolClearedEvent": {} | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| diff --git a/test/discovery_and_monitoring/unified/serverMonitoringMode.json b/test/discovery_and_monitoring/unified/serverMonitoringMode.json | ||
| index 4b492f7d8..e44fad1bc 100644 | ||
| --- a/test/discovery_and_monitoring/unified/serverMonitoringMode.json | ||
| +++ b/test/discovery_and_monitoring/unified/serverMonitoringMode.json | ||
| @@ -5,8 +5,7 @@ | ||
| { | ||
| "topologies": [ | ||
| "single", | ||
| + "sharded" | ||
| - "sharded", | ||
| - "sharded-replicaset" | ||
| ], | ||
| "serverless": "forbid" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| diff --git a/test/server_selection_logging/replica-set.json b/test/server_selection_logging/replica-set.json | ||
| index 830b1ea51..5eba784bf 100644 | ||
| --- a/test/server_selection_logging/replica-set.json | ||
| +++ b/test/server_selection_logging/replica-set.json | ||
| @@ -184,7 +184,7 @@ | ||
| } | ||
| }, | ||
| { | ||
| - "level": "debug", | ||
| + "level": "info", | ||
| "component": "serverSelection", | ||
| "data": { | ||
| "message": "Waiting for suitable server to become available", | ||
| diff --git a/test/server_selection_logging/standalone.json b/test/server_selection_logging/standalone.json | ||
| index 830b1ea51..5eba784bf 100644 | ||
| --- a/test/server_selection_logging/standalone.json | ||
| +++ b/test/server_selection_logging/standalone.json | ||
| @@ -191,7 +191,7 @@ | ||
| } | ||
| }, | ||
| { | ||
| - "level": "debug", | ||
| + "level": "info", | ||
| "component": "serverSelection", | ||
| "data": { | ||
| "message": "Waiting for suitable server to become available", | ||
| diff --git a/test/server_selection_logging/sharded.json b/test/server_selection_logging/sharded.json | ||
| index 830b1ea51..5eba784bf 100644 | ||
| --- a/test/server_selection_logging/sharded.json | ||
| +++ b/test/server_selection_logging/sharded.json | ||
| @@ -193,7 +193,7 @@ | ||
| } | ||
| }, | ||
| { | ||
| - "level": "debug", | ||
| + "level": "info", | ||
| "component": "serverSelection", | ||
| "data": { | ||
| "message": "Waiting for suitable server to become available", | ||
| diff --git a/test/server_selection_logging/sharded.json b/test/server_selection_logging/operation-id.json | ||
| index 830b1ea51..5eba784bf 100644 | ||
| --- a/test/server_selection_logging/operation-id.json | ||
| +++ b/test/server_selection_logging/operation-id.json | ||
| @@ -197,7 +197,7 @@ | ||
| } | ||
| }, | ||
| { | ||
| - "level": "debug", | ||
| + "level": "info", | ||
| "component": "serverSelection", | ||
| "data": { | ||
| "message": "Waiting for suitable server to become available", | ||
| @@ -383,7 +383,7 @@ | ||
| } | ||
| }, | ||
| { | ||
| - "level": "debug", | ||
| + "level": "info", | ||
| "component": "serverSelection", | ||
| "data": { | ||
| "message": "Waiting for suitable server to become available", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118 changes: 118 additions & 0 deletions
118
test/collection_management/modifyCollection-errorResponse.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| { | ||
| "description": "modifyCollection-errorResponse", | ||
| "schemaVersion": "1.12", | ||
| "createEntities": [ | ||
| { | ||
| "client": { | ||
| "id": "client0", | ||
| "observeEvents": [ | ||
| "commandStartedEvent" | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "database": { | ||
| "id": "database0", | ||
| "client": "client0", | ||
| "databaseName": "collMod-tests" | ||
| } | ||
| }, | ||
| { | ||
| "collection": { | ||
| "id": "collection0", | ||
| "database": "database0", | ||
| "collectionName": "test" | ||
| } | ||
| } | ||
| ], | ||
| "initialData": [ | ||
| { | ||
| "collectionName": "test", | ||
| "databaseName": "collMod-tests", | ||
| "documents": [ | ||
| { | ||
| "_id": 1, | ||
| "x": 1 | ||
| }, | ||
| { | ||
| "_id": 2, | ||
| "x": 1 | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "tests": [ | ||
| { | ||
| "description": "modifyCollection prepareUnique violations are accessible", | ||
| "runOnRequirements": [ | ||
| { | ||
| "minServerVersion": "5.2" | ||
| } | ||
| ], | ||
| "operations": [ | ||
| { | ||
| "name": "createIndex", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "keys": { | ||
| "x": 1 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "modifyCollection", | ||
| "object": "database0", | ||
| "arguments": { | ||
| "collection": "test", | ||
| "index": { | ||
| "keyPattern": { | ||
| "x": 1 | ||
| }, | ||
| "prepareUnique": true | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "insertOne", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "document": { | ||
| "_id": 3, | ||
| "x": 1 | ||
| } | ||
| }, | ||
| "expectError": { | ||
| "errorCode": 11000 | ||
| } | ||
| }, | ||
| { | ||
| "name": "modifyCollection", | ||
| "object": "database0", | ||
| "arguments": { | ||
| "collection": "test", | ||
| "index": { | ||
| "keyPattern": { | ||
| "x": 1 | ||
| }, | ||
| "unique": true | ||
| } | ||
| }, | ||
| "expectError": { | ||
| "isClientError": false, | ||
| "errorCode": 359, | ||
| "errorResponse": { | ||
| "violations": [ | ||
| { | ||
| "ids": [ | ||
| 1, | ||
| 2 | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
--whitespace=fixis a nice add!