PYTHON-5257 - Turn on mypy disallow_any_generics #2456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepyStick
reviewed
Aug 4, 2025
pymongo/network_layer.py
Outdated
| else: | ||
| result = asyncio.get_running_loop().create_future() | ||
| # Future has been cancelled, close this connection | ||
| # Future[Any] has been cancelled, close this connection |
There was a problem hiding this comment.
Yup, good catch! Fixed.
sleepyStick
approved these changes
Aug 5, 2025
sleepyStick
pushed a commit
to sleepyStick/mongo-python-driver
that referenced
this pull request
Aug 19, 2025
gablank
reviewed
Sep 29, 2025
| hint: Optional[_IndexKeyHint] = None, | ||
| **kwargs: Any, | ||
| ) -> list: | ||
| ) -> list[str]: |
There was a problem hiding this comment.
This is not necessarily correct:
import pymongo as pm
cl = pm.MongoClient()
co = cl["test"]["test"]
co.insert_one({"x": 1})
type(next(iter(co.distinct("x")))) # int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.