Skip to content

PYTHON-5514 Specific assertions for "is" and "is not None" #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

PYTHON-5514 Specific assertions for "is" and "is not None" #2502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b4947a
better assertions for "is"
sleepyStick Aug 22, 2025
2b85824
better assertions for "is not none"
sleepyStick Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/asynchronous/test_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,7 +1319,7 @@ async def test_error_code(self):
self.assertIn(exc.code, (9, 10147, 16840, 17009))
# Just check that we set the error document. Fields
# vary by MongoDB version.
self.assertTrue(exc.details is not None)
self.assertIsNotNone(exc.details)
else:
self.fail("OperationFailure was not raised")

Expand Down
6 changes: 3 additions & 3 deletions test/asynchronous/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,9 +378,9 @@ async def test_cursor_clone(self):

async with self.client.start_session() as s:
cursor = coll.find(session=s)
self.assertTrue(cursor.session is s)
self.assertIs(cursor.session, s)
clone = cursor.clone()
self.assertTrue(clone.session is s)
self.assertIs(clone.session, s)

# No explicit session.
cursor = coll.find(batch_size=2)
Expand All @@ -392,7 +392,7 @@ async def test_cursor_clone(self):
await anext(clone)
self.assertIsNone(clone.session)
self.assertIsNotNone(clone._session)
self.assertFalse(cursor._session is clone._session)
self.assertIsNot(cursor._session, clone._session)
await cursor.close()
await clone.close()

Expand Down
2 changes: 1 addition & 1 deletion test/test_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1305,7 +1305,7 @@ def test_error_code(self):
self.assertIn(exc.code, (9, 10147, 16840, 17009))
# Just check that we set the error document. Fields
# vary by MongoDB version.
self.assertTrue(exc.details is not None)
self.assertIsNotNone(exc.details)
else:
self.fail("OperationFailure was not raised")

Expand Down
6 changes: 3 additions & 3 deletions test/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,9 +378,9 @@ def test_cursor_clone(self):

with self.client.start_session() as s:
cursor = coll.find(session=s)
self.assertTrue(cursor.session is s)
self.assertIs(cursor.session, s)
clone = cursor.clone()
self.assertTrue(clone.session is s)
self.assertIs(clone.session, s)

# No explicit session.
cursor = coll.find(batch_size=2)
Expand All @@ -392,7 +392,7 @@ def test_cursor_clone(self):
next(clone)
self.assertIsNone(clone.session)
self.assertIsNotNone(clone._session)
self.assertFalse(cursor._session is clone._session)
self.assertIsNot(cursor._session, clone._session)
cursor.close()
clone.close()

Expand Down
Loading