Skip to content

PYTHON-5569: [Build Failure] Spec Resync job is failing silently #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 29, 2025
Merged

PYTHON-5569: [Build Failure] Spec Resync job is failing silently #2553

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
16a485c
catch patch errors and show them in the PR
sleepyStick Sep 22, 2025
b8fdcc1
python 3712 was completed (i think)
sleepyStick Sep 22, 2025
313120a
script should exit if fail
sleepyStick Sep 22, 2025
ffdaba0
not sure why this was changed? but i think we still need this patch
sleepyStick Sep 22, 2025
4322cc5
ran resync-all-specs
sleepyStick Sep 22, 2025
a4664e2
create patch for python 5529
sleepyStick Sep 22, 2025
1042b82
wait these shouldn't have been added back (remove support for mongodb…
sleepyStick Sep 22, 2025
20cb829
wait this shouldn't be here (python 3712)?
sleepyStick Sep 23, 2025
fb37dc7
open telemetry stuff (i dont think we do anything for it yet so i'm j…
sleepyStick Sep 23, 2025
b1297dd
use recursive find instead of two rms
sleepyStick Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .evergreen/remove-unimplemented-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ rm $PYMONGO/test/collection_management/modifyCollection-*.json

# PYTHON-5248 - Remove support for MongoDB 4.0
rm $PYMONGO/test/**/pre-42-*.json
rm $PYMONGO/test/**/**/pre-42-*.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to remove files in test/discovery_and_monitoring/errors/pre-42-*.json
(I thought the ** was a recursive wildcard? but every time i ran the resync spec script those files would pop up so i added it explicitly?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using find instead. I'm not a bash expert but the rules for ** aren't like in Path/.glob.

Try: find /$PYMONGO /test -type f -name 'pre-42-*.json' -delete

Note that -f means that this isn't going to match directories.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo good idea! I've replaced the two rms with the find instead. Thanks~


# PYTHON-3359 - Remove Database and Collection level timeout override
rm $PYMONGO/test/csot/override-collection-timeoutMS.json
Expand Down
20 changes: 12 additions & 8 deletions .evergreen/scripts/resync-all-specs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,18 @@ def resync_specs(directory: pathlib.Path, errored: dict[str, str]) -> None:
print("Done syncing specs")


def apply_patches():
def apply_patches(errored):
print("Beginning to apply patches")
subprocess.run(["bash", "./.evergreen/remove-unimplemented-tests.sh"], check=True) # noqa: S603, S607
subprocess.run(
["git apply -R --allow-empty --whitespace=fix ./.evergreen/spec-patch/*"], # noqa: S607
shell=True, # noqa: S602
check=True,
)
try:
subprocess.run(
["git apply -R --allow-empty --whitespace=fix ./.evergreen/spec-patch/*"], # noqa: S607
shell=True, # noqa: S602
check=True,
stderr=subprocess.PIPE,
)
except CalledProcessError as exc:
errored["applying patches"] = exc.stderr


def check_new_spec_directories(directory: pathlib.Path) -> list[str]:
Expand Down Expand Up @@ -85,7 +89,7 @@ def write_summary(errored: dict[str, str], new: list[str], filename: Optional[st
pr_body += "\n -".join(succeeded)
pr_body += "\n"
if len(errored) > 0:
pr_body += "\n\nThe following spec syncs encountered errors:\n -"
pr_body += "\n\nThe following spec syncs encountered errors:"
for k, v in errored.items():
pr_body += f"\n -{k}\n```{v}\n```"
pr_body += "\n"
Expand All @@ -106,7 +110,7 @@ def main(args: Namespace):
directory = pathlib.Path("./test")
errored: dict[str, str] = {}
resync_specs(directory, errored)
apply_patches()
apply_patches(errored)
new = check_new_spec_directories(directory)
write_summary(errored, new, args.filename)

Expand Down
1 change: 1 addition & 0 deletions .evergreen/scripts/resync-all-specs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/usr/bin/env bash
# Run spec syncing script and create PR
set -eu
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should make errors more visible to us


# SETUP
SRC_URL="https://github.com/mongodb/specifications.git"
Expand Down
10 changes: 5 additions & 5 deletions .evergreen/spec-patch/PYTHON-3712.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
diff --git a/test/discovery_and_monitoring/unified/serverMonitoringMode.json b/test/discovery_and_monitoring/unified/serverMonitoringMode.json
index 4b492f7d8..e44fad1bc 100644
index e44fad1b..4b492f7d 100644
--- a/test/discovery_and_monitoring/unified/serverMonitoringMode.json
+++ b/test/discovery_and_monitoring/unified/serverMonitoringMode.json
@@ -5,8 +5,7 @@
@@ -5,7 +5,8 @@
{
"topologies": [
"single",
+ "sharded"
- "sharded",
- "sharded-replicaset"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already did this ticket but for whatever reason the spec repo still has this one instance of sharded-replicaset so we're applying this patch to keep it out of our tests. (I've made a comment on the drivers ticket asking why its still in the spec repo)

- "sharded"
+ "sharded",
+ "sharded-replicaset"
],
"serverless": "forbid"
}
Loading
Loading