-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5024 - Add 3.14t as a standard Python matrix version #2563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You'll need to skip free-threaded python for auth-enterprise macos/rhel as well. |
Oh, and the lock file update caused a typing failure from a newer version of mypy. |
PYPYS = ["pypy3.10"] | ||
ALL_PYTHONS = CPYTHONS + PYPYS | ||
MIN_MAX_PYTHON = [CPYTHONS[0], CPYTHONS[-1]] | ||
MIN_MAX_PYTHON = [CPYTHONS[0], CPYTHONS[-2]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could make 3.14t second to last and avoid this change
We'll want to schedule a full build of all the tasks that use python3.14t. |
display_name = get_variant_name("Auth Enterprise", host) | ||
tasks = [".test-non-standard .auth"] | ||
if host != "rhel8": | ||
tasks = [".test-non-standard .auth !.free-threaded"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link to the PYTHON ticket for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a ticket for adding free-threading support, we do have one for documenting that only windows supports it: PYTHON-5586. Is that what you want linked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.