Skip to content

Conversation

caseyclements
Copy link
Contributor

Creates new method create_test_standard_auth_tasks that creates tasks "test-standard-auth-*" that only include sharded-cluster. Because the list of clusters is one, we get a task that contains auth and python 3.14t.

…: test-standard-auth that only include sharded-clusters
@caseyclements caseyclements requested a review from a team as a code owner October 6, 2025 20:14
return tasks


def create_test_standard_auth_tasks():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the auth variant generation functions so their tasks use test-standard-auth instead of test-non-standard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"All auth variant generation methods should have their tasks updated from .test-non-standard to .test-standard-auth to use these new tasks." This line wasn't / isn't clear to me. It appeared like it would be a natural result of the new create_test_standard_auth_tasks().

Do I have to manually edit variants.yml?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you edit the variant function(s) to use the new task tag

@caseyclements
Copy link
Contributor Author

Disregard Link Check failures. Red herring.

Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run a patch build with all of the auth variants?

@caseyclements
Copy link
Contributor Author

caseyclements commented Oct 7, 2025

Can you run a patch build with all of the auth variants?

Patch 379 - Updated create_enterprise_auth_variants

(This is more than just the auth variants.)

@caseyclements caseyclements merged commit d595913 into mongodb:master Oct 7, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants