Skip to content

Conversation

@comandeo-mongo
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 9, 2026 09:07
@comandeo-mongo comandeo-mongo requested a review from a team as a code owner January 9, 2026 09:07
@comandeo-mongo comandeo-mongo requested a review from jamis January 9, 2026 09:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates SSL/TLS configuration to use MongoDB orchestration-based certificate paths instead of relying solely on local certificate files. The changes enable tests to work with certificates generated by the evergreen/drivers-tools infrastructure, making the test suite more compatible with CI environments.

Key changes:

  • Added support for "yes" as a valid value for the SSL environment variable (in addition to "ssl")
  • Introduced new evergreen certificate path methods that point to orchestration-generated certificates
  • Switched several build variants from test-mlaunch to run-main-test-suite to use orchestration
  • Updated server setup code to use SpecConfig for proper SSL configuration

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
spec/support/spec_config.rb Added evergreen certificate path methods, reorganized cert path configuration, updated SSL env var parsing, added debug output
spec/mongo/socket/ssl_spec.rb Updated tests to use generic cert paths instead of local-only paths, removed tests for encrypted keys and intermediate certs, simplified key_string to reference cert_string
spec/integration/ssl_uri_options_spec.rb Skipped test pending RUBY-3749 resolution
spec/integration/srv_monitoring_spec.rb Skipped two tests pending RUBY-3749 resolution
spec/integration/reconnect_spec.rb Skipped test pending RUBY-3749 resolution
.evergreen/lib/server_setup.rb Updated to use SpecConfig for client initialization instead of raw MONGODB_URI
.evergreen/config/standard.yml.erb Changed task references from test-mlaunch to run-main-test-suite
.evergreen/config/common.yml.erb Added DRIVERS_TOOLS to environment variables for test execution
.evergreen/config.yml Changed task references from test-mlaunch to run-main-test-suite, added DRIVERS_TOOLS to environment variables

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant