minor: refactor faas tests to validate metadata #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Oct 16, 2024
src/cmap/establish/handshake.rs
Outdated
| } | ||
|
|
||
| #[cfg(test)] | ||
| pub(crate) static METADATA: std::sync::OnceLock<ClientMetadata> = std::sync::OnceLock::new(); |
There was a problem hiding this comment.
This gives me the heebie-jeebies but since it's explicitly test-restricted and a lot less disruptive than trying to propagate the computed metadata back up the ownership/worker hierarchy it seemed the less-bad option.
|
evergreen retry |
abr-egn
commented
Oct 17, 2024
| } | ||
|
|
||
| #[cfg(test)] | ||
| #[allow(clippy::incompatible_msrv)] |
There was a problem hiding this comment.
This should be fine since we only test on the latest release and cfg(test) isn't transitive, so someone using <1.70 (when OnceLock was introduced) can still use the mongodb crate fine, including in their tests.
isabelatkinson
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preliminary to RUST-2000, which will need this kind of observability. (And we probably should have been doing it from the start anyway.)