-
Notifications
You must be signed in to change notification settings - Fork 185
Add fuzz test to handle length math issues with Messages and Headers #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a118e91
Devin message header fuzz
pmeredit 041093f
Cleanup Devin's imports
pmeredit 91cf2ed
Remove weird pointless file Devin added
pmeredit e2fc684
Make the fuzz test test what we actually care about
pmeredit 6d92b56
Make the fuzz test better, still relying on infra setup by Devin at l…
pmeredit 72407e1
Fix bug found by fuzz test
pmeredit 421ef81
Fix bug found by fuzz test in totality!
pmeredit a9acfdb
Add fuzzer to CI. Devin could do this, but I just did it myself becau…
pmeredit f98c827
Fix bizzare change for MessageFlags from binary to hex introduced by …
pmeredit 82b8183
Fix install-fuzzer
pmeredit eac43d4
Fix run-fuzzer in the exact same way, heh
pmeredit 2a128de
Fix public visibility that Devin added for no reason
pmeredit 9cafae2
Fix accidental private api leaking
pmeredit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,15 @@ | ||
#![no_main] | ||
use libfuzzer_sys::fuzz_target; | ||
use mongodb::cmap::conn::wire::header::Header; | ||
use mongodb::cmap::conn::wire::{header::Header, message::Message}; | ||
|
||
fuzz_target!(|data: &[u8]| { | ||
if data.len() < Header::LENGTH { | ||
return; | ||
} | ||
if let Ok(header) = Header::from_slice(data) { | ||
if header.length < 0 { | ||
panic!("Negative length detected: {}", header.length); | ||
} | ||
if header.length as usize > std::usize::MAX - Header::LENGTH { | ||
panic!("Integer overflow detected in length calculation"); | ||
} | ||
let total_size = Header::LENGTH + header.length as usize; | ||
if total_size > data.len() { | ||
return; | ||
let data = &data[Header::LENGTH..]; | ||
if let Ok(message) = Message::read_from_slice(data, header) { | ||
let _ = message; | ||
} | ||
} | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was particularly bad. Ok, the length is negative because it's random. This wasn't testing any actual driver code 😂