Skip to content

Fix read_document_bytes unchecked conversion bug #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Fix read_document_bytes unchecked conversion bug #1274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/bson_util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,14 @@ fn num_decimal_digits(mut n: usize) -> usize {

/// Read a document's raw BSON bytes from the provided reader.
pub(crate) fn read_document_bytes<R: Read>(mut reader: R) -> Result<Vec<u8>> {
let length = reader.read_i32_sync()?;
let length = Checked::new(reader.read_i32_sync()?);

let mut bytes = Vec::with_capacity(length as usize);
bytes.write_all(&length.to_le_bytes())?;
let mut bytes = Vec::with_capacity(length.try_into()?);
bytes.write_all(&length.try_into::<u32>()?.to_le_bytes())?;

reader.take(length as u64 - 4).read_to_end(&mut bytes)?;
reader
.take((length - 4).try_into()?)
.read_to_end(&mut bytes)?;

Ok(bytes)
}
Expand Down