-
Notifications
You must be signed in to change notification settings - Fork 181
RUST-2245 Implement GSSAPI auth support for Windows #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattChiaravalloti
wants to merge
16
commits into
mongodb:main
Choose a base branch
from
mattChiaravalloti:RUST-2245
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fe75d16
RUST-2245: Fix typo in e2e test logging
mattChiaravalloti 9dda3b3
RUST-2245: Initial second attempt at GSSAPI on Windows
mattChiaravalloti 4186779
RUST-2245: Refactor service_principal name creation
mattChiaravalloti 3cf15d0
RUST-2245: Separate windows and non-windows implementations
mattChiaravalloti 9175eb2
RUST-2245: Update windows implementation to use windows api instead o…
mattChiaravalloti f95788b
Merge branch 'main' into RUST-2245
mattChiaravalloti 08ca68a
RUST-2245: Fix rustfmt
mattChiaravalloti 0d6858b
RUST-2245: Refactor to share more common code
mattChiaravalloti 56661ab
RUST-2245: Standardize requirement of user_principal and use better n…
mattChiaravalloti a32a408
RUST-2245: More clean up, refactoring, and renaming
mattChiaravalloti 6bb9227
RUST-2245: Static analysis fixes
mattChiaravalloti 6654548
RUST-2245: Update e2e tests to handle windows
mattChiaravalloti 9a3ffa8
RUST-2245: Fix evergreen tasks
mattChiaravalloti 726e9f8
RUST-2245: Add more comments
mattChiaravalloti 51c98bc
RUST-2245: Reduce unsafe to smaller scopes, add nosemgrep comments
mattChiaravalloti 71b3f68
RUST-2245: Refactor GssapiAuthenticator
mattChiaravalloti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,7 +56,7 @@ gcp-oidc = ["dep:reqwest"] | |
gcp-kms = ["dep:reqwest"] | ||
|
||
# Enable support for GSSAPI (Kerberos) authentication. | ||
gssapi-auth = ["dep:cross-krb5", "dns-resolver"] | ||
gssapi-auth = ["dep:cross-krb5", "dep:windows-sys", "dns-resolver"] | ||
|
||
zstd-compression = ["dep:zstd"] | ||
zlib-compression = ["dep:flate2"] | ||
|
@@ -80,7 +80,6 @@ chrono = { version = "0.4.7", default-features = false, features = [ | |
"clock", | ||
"std", | ||
] } | ||
cross-krb5 = { version = "0.4.2", optional = true, default-features = false } | ||
derive_more = "0.99.17" | ||
derive-where = "1.2.7" | ||
flate2 = { version = "1.0", optional = true } | ||
|
@@ -235,6 +234,13 @@ features = ["serde", "serde_json-1"] | |
rustdoc-args = ["--cfg", "docsrs"] | ||
all-features = true | ||
|
||
# Target-specific dependencies for GSSAPI authentication | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be honest, I've never had to do this before in a |
||
[target.'cfg(not(windows))'.dependencies] | ||
cross-krb5 = { version = "0.4.2", optional = true, default-features = false } | ||
|
||
[target.'cfg(windows)'.dependencies] | ||
windows-sys = { version = "0.60", optional = true, features = ["Win32_Security_Authentication_Identity", "Win32_Security_Credentials", "Win32_Foundation", "Win32_System", "Win32_System_Rpc"] } | ||
|
||
[lints.rust] | ||
unexpected_cfgs = { level = "warn", check-cfg = [ | ||
'cfg(mongodb_internal_tracking_arc)', | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
${PROJECT_DIRECTORY}
onwindows-64-vs2017-small
was causing "working_dir could not be found" errors. I checked the rest ofconfig.yml
and it seems like the majority ofworking_dir
values are set tosrc
. I only chose${PROJECT_DIRECTORY}
initially since I based this function on the aws auth functions.