Zero-copy raw batch cursor API #1540
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
requested review from
abr-egn
and removed request for
isabelatkinson
Contributor
|
I'm a bit confused - this looks like it doesn't follow either of the approaches I proposed. Can you talk me through how this follows from that? |
Author
|
@abr-egn Sorry for the delayed response in the discussion thread. Still speaking with the team, but we wanted to get a pr to get things rolling. Not looking for a review or for this to be merged in right now. I understand it doesn't line up with the approaches you laid out in the discussion thread but its what we have working and a base to build off of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For background, see the discussion: #1529