Skip to content

fix: logout and minor improvements #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 3, 2025
Merged

fix: logout and minor improvements #4177

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
79e8b2f
fix telemetry with new profile
blva Sep 2, 2025
d924147
clarify what profile is being logged out
blva Sep 2, 2025
dc1feae
only set profile if it's the default
blva Sep 2, 2025
1f3cd34
Merge remote-tracking branch 'origin/master' into sa-logout
blva Sep 2, 2025
b55400c
update
blva Sep 2, 2025
c037cb1
address comment: update text
blva Sep 3, 2025
1901a68
address comment
blva Sep 3, 2025
30c62f1
lint
blva Sep 3, 2025
8aa04ac
Update internal/cli/auth/logout.go
blva Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions internal/cli/auth/logout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,14 +174,14 @@ func LogoutBuilder() *cobra.Command {
var message, entry string
var err error

fromProfile := fmt.Sprintf(" from profile %s?", opts.config.Name())
logoutMessage := fmt.Sprintf("Are you sure you want to log out of profile %s ", opts.config.Name())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the space and put the space at the beginning all other messages so noAuth scenario doesn't end with <space><question mark>:
Are you sure you want to log out of profile %s ?

switch opts.config.AuthType() {
case config.APIKeys:
entry = opts.config.PublicAPIKey()
message = "Are you sure you want to log out of account with public API key %s" + fromProfile
message = logoutMessage + "with public API key %s?"
case config.ServiceAccount:
entry = opts.config.ClientID()
message = "Are you sure you want to log out of service account %s" + fromProfile
message = logoutMessage + "with service account %s?"
case config.UserAccount:
entry, err = opts.config.AccessTokenSubject()
if err != nil {
Expand All @@ -192,10 +192,10 @@ func LogoutBuilder() *cobra.Command {
return ErrUnauthenticated
}

message = "Are you sure you want to log out of account %s" + fromProfile
message = logoutMessage + "with user account %s?"
case config.NoAuth, "":
entry = opts.config.Name()
message = "Are you sure you want to clear profile %s?"
message = logoutMessage + "?"
}

opts.Entry = entry
Expand Down
Loading