Skip to content

Conversation

@filipcirtog
Copy link
Collaborator

Summary

In this PR, we removed the recompute licenses step from the default make manager target and restricted it to releases only. However, an orphaned make recompute licenses target was left behind, which makes the manager target fail.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@filipcirtog filipcirtog requested a review from a team as a code owner September 10, 2025 12:50
@filipcirtog filipcirtog changed the title Removal of orphan target Removal of orphan makefile target Sep 10, 2025
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 🎉

@filipcirtog filipcirtog merged commit 788bd79 into main Sep 10, 2025
22 checks passed
@filipcirtog filipcirtog deleted the eliminate-removed-make-target branch September 10, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants